Fix ingress hostname extract logic for syncCatalog #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
In the current implementation, when user enable
syncCatalog.ingress.enabled, the control plane will register service with its ingress rule host to consul as address.However, if the ingress DNS is leverage consul, the host name won't be existed at the moment, and consul will solve it into
127.0.0.1at the end.Comparing with the case of
syncCatalog.ingress.loadBalancerIPsenabled, it should be registered withingress.Status.LoadBalancer.Ingress[*].Hostnameto make consul solve the service DNS to the cluster load balancer rather than the non-exists host entry.How I've tested this PR
How I expect reviewers to test this PR
Checklist