-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSideNav
- Component branch (HDS-3800)
#2384
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]> Co-authored-by: Jory Tindall <[email protected]>
9224755
to
b4973a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few suggestions. considering the age of this branch, I suggest we rebase before we get this in. let me know if you'd like me to handle this on your behalf
KB: Thanks! I had already rebased previously and I don't see any new changes in main
.
packages/components/src/styles/@hashicorp/design-system-components.scss
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/app-side-nav/portal/index-test.js
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/app-side-nav/index-test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex <[email protected]>
π Summary
If merged, this PR will add the
AppSideNav
component to HDS but will not publish it. It will also un-publish the relatedAppHeader
component. (See related memo)π οΈ Detailed description
The majority of code was duplicated from the
SideNav
and then modified to implement the newAppSideNav
component.Major differences of note:
AppSideNav
has an updated visual design using lighter colors than theSideNav
:header
,:footer
,:body
,:root
:logo
&:actions
child named blocks were removed (used in old :header)Header
andHeader::HomeLink
child components were removed.AppHeader
which already includes this(Spike of restructured List and ListTitle which may be explored in later iterations)
(Internal references: RFC, Meta CRD)
π External links
π Component checklist
[ ] A changelog entry was added via [Changesets](Removed changelog as component will not be published) (https://github.com/changesets/changesets) if needed (see templates here)π¬ Please consider using conventional comments when reviewing this PR.