Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showcase: convert ShwLogo to gts #2423

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Showcase: convert ShwLogo to gts #2423

merged 2 commits into from
Sep 24, 2024

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Sep 17, 2024 •
edited
Loading

📌 Summary

If merged, this PR would convert the ShwLogo::DesignSystem component to .gts.

🔗 External links

Jira ticket: HDS-3835

👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@shleewhite shleewhite requested review from aklkv and a team September 17, 2024 15:20
@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 24, 2024 3:20pm
hds-website ✅ Ready (Inspect) Visit Preview Sep 24, 2024 3:20pm

shleewhite
shleewhite commented Sep 17, 2024
View reviewed changes
showcase/.eslintrc.js Outdated Show resolved Hide resolved
shleewhite
shleewhite commented Sep 17, 2024
View reviewed changes
showcase/app/components/shw/logo/design-system.gts Outdated
aria-hidden="true"
>
<defs>
<linearGradient
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: without changing the linting rules, this file would always error saying that linearGradient isn't defined.

@Dhaulagiri
Copy link
Contributor

upgrade eslint-plugin-ember a major version

It's my preference but I also think a requirement that we extract this into a separate PR and do this for all the packages at once. Otherwise the new major will resolve for everything and lead to the issues you're seeing getting the component tests to pass.

aklkv
aklkv approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aklkv aklkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻 This components is something we might think to refactor, I have been thinking that having non modified svg is overkill to have it's own component @didoo but this would have to be in the future

@didoo
Copy link
Contributor

didoo commented Sep 20, 2024

@shleewhite is there something that needs to be done in this branch to get the tests passed?

@shleewhite
Copy link
Contributor Author

@shleewhite is there something that needs to be done in this branch to get the tests passed?

Not on this branch, I need to merge the eslint upgrade pr first and then I think this pr will be unblocked #2427

zamoore
zamoore approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shleewhite shleewhite changed the base branch from main to hds-3805/update-eslint-plugin-ember September 23, 2024 21:18
@shleewhite shleewhite force-pushed the hds-3805/update-eslint-plugin-ember branch 2 times, most recently from c87f966 to 2c53f5c Compare September 24, 2024 15:02
Base automatically changed from hds-3805/update-eslint-plugin-ember to main September 24, 2024 15:14
@shleewhite shleewhite merged commit 6e5db1b into main Sep 24, 2024
14 checks passed
@shleewhite shleewhite deleted the hds-3835/gts-shw-logo branch September 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamoore zamoore zamoore approved these changes

@aklkv aklkv aklkv approved these changes

Assignees
No one assigned
Labels
showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shleewhite @Dhaulagiri @didoo @aklkv @zamoore @hashibot-hds