Showcase .gts - Shw::Autoscrollable
#2426
Open
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name, or `yarn run lint:hbs` would fail
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
commented
Sep 17, 2024
| <div | ||
| class="shw-autoscrollable__container" | ||
| ...attributes | ||
| {{this.autoscroll}} |
There was a problem hiding this comment.
Note: I tried to move the autoscroll modifier definition outside of the class/Component declaration, but it didn't work: for some reasons that I don't understand only the last instance actually called the centerScrollableArea function.
If you know why and want to give it a go and try do it "properly" feel free to push directly in the branch.
There was a problem hiding this comment.
I did attempt to do the same but gave up as this modifier is closely tide to this components. It might be good to follow up as a stand alone PR in the future
aklkv
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Detailed description
In this PR I have:
Shw::Autoscrollabletemplate code under the unified.gtsfiletemplate-registry.tsfile to include theindexfile name (as did in previous PR)Preview: https://hds-showcase-git-showcase-gts-autoscrollable-hashicorp.vercel.app/components/rich-tooltip#collision-detection
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3829
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.