Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: try to merge resources of tags which share the same normalize name #4331

Closed
wants to merge 2 commits into from

Conversation

wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Jul 26, 2024

fixes #4323

there are two similar tags share the same normalizedName (note one tag ends with a dot(.) ) in devcenter.json, we can merge these two tags' operation into the same resource. This may seem like a swagger issue, but we can address it here since fixing swagger could take longer.

Attached NetworkConnections: https://github.com/Azure/azure-rest-api-specs/blob/09741dc7c9e43a8f9401d782186cac723dc4af71/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L1260C1-L1261C1
Attached NetworkConnections. : https://github.com/Azure/azure-rest-api-specs/blob/09741dc7c9e43a8f9401d782186cac723dc4af71/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L628

@wuxu92 wuxu92 marked this pull request as draft July 26, 2024 03:36
@manicminer manicminer self-requested a review July 26, 2024 05:59
@wuxu92 wuxu92 marked this pull request as ready for review July 26, 2024 07:39
@stephybun stephybun self-assigned this Sep 30, 2024
@stephybun stephybun removed the request for review from manicminer October 10, 2024 12:53
@stephybun
Copy link
Member

Thanks for attempting to fix this @wuxu92.

We recently merged #4307 which consists of a refactor of the project as well as a change in approach to how we load and parse the Swagger files. As a result I believe this issue is now fixed as I see all of the available operations for NetworkConnections in the API definitions now.

Closing this out for now since this is resolved.

@stephybun stephybun closed this Oct 11, 2024
@wuxu92
Copy link
Collaborator Author

wuxu92 commented Oct 11, 2024

@stephybun Thanks for the update and congrats on merging the Pandora Parser refactor! Could you please review PR #4406? The issue it addresses still exists after 4307 was merged.

@wuxu92 wuxu92 deleted the importer/merge_likely_tags branch October 11, 2024 06:25
@stephybun
Copy link
Member

Thanks for bringing this to my attention @wuxu92. I need to fix some lingering side effects from the refactor to bring the project into a stable state. Once that's done I'll take a look at #4406, please bear with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants