Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests using ConfigFile and ConfigDirectory with plannable import #465

Merged
merged 21 commits into from
Mar 31, 2025
Merged

Add tests using ConfigFile and ConfigDirectory with plannable import #465

merged 21 commits into from
Mar 31, 2025
+218 −94

Conversation

bbasata
Copy link
Contributor

@bbasata bbasata commented Mar 24, 2025 •
edited
Loading

To be merged after #461

This change:

  • Removes error that says step.ConfigFile and step.ConfigDirectory are not supported with plannable import
  • Adds tests to cover the use of ConfigFile and ConfigDirectory with plannable import
  • Renames Id to ID in ImportStateKinds
  • Adds ImportStateKind.plannable() to simplify testStepNewImportState logic
  • Extracts check & verify logic from testStepNewImportState into new unexported functions, to help keep the function readable and maintainable

We will document the test framework's behavior of using ConfigFile and ConfigDirectory without modification, unlike inline Config.

@bbasata bbasata requested a review from a team as a code owner March 24, 2025 17:03
rainkwan
rainkwan previously approved these changes Mar 25, 2025
View reviewed changes
@austinvalle austinvalle added this to the v1.13.0 milestone Mar 25, 2025
austinvalle
austinvalle previously approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some nits for consideration. Love all the new testing we're producing with this work! 🚀

@bbasata
Copy link
Contributor Author

bbasata commented Mar 26, 2025

To be merged after #461

@bbasata bbasata mentioned this pull request Mar 26, 2025
Open
Base automatically changed from import-as-first-test-step to main March 27, 2025 13:29
@bbasata bbasata dismissed stale reviews from austinvalle and rainkwan March 27, 2025 13:29

The base branch was changed.

@bbasata
Copy link
Contributor Author

bbasata commented Mar 28, 2025

Resolved merge conflicts 😃

@bbasata bbasata requested a review from a team March 28, 2025 01:41
@bbasata bbasata merged commit c4be868 into main Mar 31, 2025
39 checks passed
@bbasata bbasata deleted the import-config-file-and-directory branch March 31, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvalle austinvalle

@rainkwan rainkwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbasata @austinvalle @rainkwan