Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_analytics_solution_resource - updated import validation to include () and [] #27359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MBH999
Copy link

@MBH999 MBH999 commented Sep 11, 2024

I have updated the validation to ensure that it allows both Solution(WorkspaceName) and Solution[WorkspaceName] when importing resources

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

When importing Log Analytics Solutions into TFState, some will failed due to them not being the the correct format expected by this provider.

Typically, the LA Solution will be in the format of Solution(WorkspaceName) (note; using parenthesis), however on some resources, they will be in the format of Solution[WorkspaceName] (note; using brackets).

Currently the provider will throw an error suggesting that the solution has to be in the parenthesis format. I have updated the validation so that it will allow both parenthesis and brackets as both are possible. If the format does not match these, then it will throw an error.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_log_analytics_solution - support for importing resource IDs with parenthesis and brackets.

This is a (please select all that apply):

  • [X ] Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #10230

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…ed the validation to ensure that it allows both Solution(WorkspaceName) and Solution[WorkspaceName] when importing resources
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @MBH999. Could you also add a test for this?

@@ -224,13 +224,31 @@ func (s LogAnalyticsSolutionResource) Read() sdk.ResourceFunc {
// expecting resp.Name to be in format "SolutionName(WorkspaceName)".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the comment here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support import of existing Log Analytics Solutions with name format Solution[WorkspaceName]
3 participants