Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_key_vault_secret_versions #27393

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ned1313
Copy link
Contributor

@ned1313 ned1313 commented Sep 13, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This is a new data source that will retrieve the versions of an existing Key Vault Secret. The returned value is called versions and is a list of each version and its attributes. It does not include the secret value for each version. The number of returned results can be set with the max_results argument that defaults to 25.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
$ make acctests SERVICE='keyvault' TESTARGS='-run=TestAccDataSourceKeyVaultSecretVersions_complete' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/keyvault -run=TestAccDataSourceKeyVaultSecretVersions_complete -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceKeyVaultSecretVersions_complete
=== PAUSE TestAccDataSourceKeyVaultSecretVersions_complete
=== CONT  TestAccDataSourceKeyVaultSecretVersions_complete
--- PASS: TestAccDataSourceKeyVaultSecretVersions_complete (824.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      824.387s

$ make acctests SERVICE='keyvault' TESTARGS='-run=TestAccDataSourceKeyVaultSecretVersions_basic' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/keyvault -run=TestAccDataSourceKeyVaultSecretVersions_basic -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceKeyVaultSecretVersions_basic
=== PAUSE TestAccDataSourceKeyVaultSecretVersions_basic
=== CONT  TestAccDataSourceKeyVaultSecretVersions_basic
--- PASS: TestAccDataSourceKeyVaultSecretVersions_basic (826.40s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      826.415s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_key_vault_secret_versions - new data source to retrieve versions of a secret [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for enumerating all versions of a keyvault secret
2 participants