-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove irrelevant link to issue. #36666
Conversation
The docs link to #13549 which was closed. Gathering anything relevant or of use from that ~100 comment long issue thread is not a particularly useful endeavor, so given that the information is true and not likely to be changed, simply removing the issue link and leaving the warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this!
Co-authored-by: Rose M Koron <[email protected]>
@rkoron007 thanks for the changes! Somehow when I committed your changes it automatically "dismissed your stale review" (ha) so if you could re-approve I would appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! ✅
We should remove the same link from here too: https://github.com/hashicorp/terraform/blob/main/website/docs/language/meta-arguments/lifecycle.mdx?plain=1#L58 |
Per #36666, this link is more confusing than it is beneficial.
The docs link to #13549 which was closed. Gathering anything relevant or of use from that ~100 comment long issue thread is not a particularly useful endeavor, so given that the information is true and not likely to be changed, simply removing the issue link and leaving the warning.