Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant link to issue. #36666

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Remove irrelevant link to issue. #36666

merged 2 commits into from
Mar 10, 2025

Conversation

crw
Copy link
Contributor

@crw crw commented Mar 10, 2025

The docs link to #13549 which was closed. Gathering anything relevant or of use from that ~100 comment long issue thread is not a particularly useful endeavor, so given that the information is true and not likely to be changed, simply removing the issue link and leaving the warning.

The docs link to #13549 which was closed. Gathering anything relevant or of use from that ~100 comment long issue thread is not a particularly useful endeavor, so given that the information is true and not likely to be changed, simply removing the issue link and leaving the warning.
@crw crw requested review from a team as code owners March 10, 2025 18:38
@crw crw added documentation 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry labels Mar 10, 2025
@crw crw linked an issue Mar 10, 2025 that may be closed by this pull request
rkoron007
rkoron007 previously approved these changes Mar 10, 2025
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this!

@crw
Copy link
Contributor Author

crw commented Mar 10, 2025

@rkoron007 thanks for the changes! Somehow when I committed your changes it automatically "dismissed your stale review" (ha) so if you could re-approve I would appreciate it!

Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! ✅

@jbardin
Copy link
Member

jbardin commented Mar 10, 2025

@crw crw merged commit 9646c3d into main Mar 10, 2025
12 of 13 checks passed
@crw crw deleted the crw-patch-1 branch March 10, 2025 22:21
crw added a commit that referenced this pull request Mar 10, 2025
Per #36666, this link is more confusing than it is beneficial.
@crw
Copy link
Contributor Author

crw commented Mar 10, 2025

@jbardin #36668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closed issue still referenced in documentation
3 participants