stacks: fix errors processing index keys of removed blocks #36673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
dsa0x
approved these changes
Mar 12, 2025
dsa0x
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Is there a valid test case for this change?
There was a problem hiding this comment.
yeah, these lines: https://github.com/hashicorp/terraform/pull/36673/files#diff-8e06148766db6ff45ec109b3daef7414644336b36abbd1a08a6e0beda95911c7R40-R41
They verify the two new removed blocks are returning errors as expected
DanielMSchmidt
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work addressing feedback for the
removedblock in Stacks.Currently, we were assuming that the
for_eachattribute was always being copied directly into the key of thefromattribute. This isn't necessarily true - there's a test case that has been added that demonstrates this.This PR updates the Stacks internals to differentiate between the "instance key" of a removed block (which is the output of the for_each evaluation) and the instance key of the address in the from attribute. The each attribute needs to be mentioned in the from attribute, but it doesn't have to be a 1:1 mapping. Previously, we would just check the instance key for direct matches between instances in state, components and removed blocks. Now, we actively check the from attribute of the removed block when making such comparisons.