Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend helm chart to improve controller availability #899

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MM53
Copy link

@MM53 MM53 commented Aug 29, 2024

While installing the operator in our setup we did some modifications to the resources to improve the availability of the controller Pods. Since those changes might also help others, it would be great to include them in the Helm chart.

Following changes were applied:

  • Add a value to set the priorityClassName of the Deployment and Jobs. This supports proper handling of scheduling and eviction in case of low resources
  • Allow to configure topologySpreadConstraints of the controller Pods. This provides a more detailed control of Pod placement than affinity rules.
  • Add an optional PodDisruptionBudget to avoid evicting all controller Pods at once in case there are multiple replicas.

Please let me know what you think about these changes.

@MM53 MM53 requested a review from a team as a code owner August 29, 2024 09:37
Copy link

hashicorp-cla-app bot commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@andrewseling
Copy link

@MM53 are you still interested in contributing this? I need the priorityClassName change and would like to help push this across the line if so.

@MM53
Copy link
Author

MM53 commented Feb 13, 2025

Yes, this change would still be helpful for us.

@andrewseling
Copy link

@MM53 It seems like checks got stuck on this PR. Do you want to re-run them or open a new PR to kick them off again?

I'm told that once the checks (including CLA) all pass, this PR will be sent to the reviewing team for their approval.

You can also reach out to me at firstName.lastName @ (employer in my profile).com if you want to work through this more directly.

@MM53 MM53 force-pushed the improve-deployment-availability branch from be653f9 to 2f85481 Compare February 21, 2025 07:37
@MM53
Copy link
Author

MM53 commented Feb 21, 2025

@andrewseling I updated the branch to resolve any conflicts, but I guess the missing check needs to be triggered by some reviewer since I don't have a possibility to run it.

@benashz benashz self-requested a review February 21, 2025 13:49
@benashz benashz self-assigned this Feb 21, 2025
@benashz benashz added helm enhancement New feature or request labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants