-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Handle deprecation router service from host #28281
base: main
Are you sure you want to change the base?
UI: Handle deprecation router service from host #28281
Conversation
CI Results: |
…AULT-30635/deprecation-router-service-from-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 thank you for adding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need the copyright header on this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pr description. While it's a lot of file changes, it all seems to make sense and look clean to me. Additionally, thank you for starting the sidebranch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need the copyright head on this file.
Description
Fixes this deprecation for ember engine router in every engine except replication (there are some other issues going on there that will have to be handled separately).
There are a lot of changes here because we have multiple engines, but the changes all fall into a few categories:
router
engine dependencies with aliasedapp-router
app-router
service within engines instead ofrouter
transition-to
within engines to use a helper which references theapp-router
service insteadLinkedBlock
(which is a core component used across engines and the main app) to useapp-router
service if available, otherwise fall back to using the regularrouter
serviceNOTE: this should not be merged until 1.18 is cut