Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lambda-extension): update distributed tracing headers warning; #28319

Conversation

aztalbot
Copy link
Contributor

@aztalbot aztalbot commented Sep 7, 2024

Description

Standard distributed tracing headers are now excluded from the cache key since hashicorp/vault-lambda-extension#145 was merged.

So, I've updated the warning about distributed tracing headers to focus on nonstandard headers. Such headers may still cause issues without consumers being aware of them. I didn't call it out, but for example: New Relic adds a vendor-specific distributed tracing header for backwards compatibility that needs to be explicitly turned off.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@aztalbot aztalbot requested a review from a team as a code owner September 7, 2024 01:34
@aztalbot aztalbot force-pushed the doc/lambda-extensions/cache-header-warning-update branch from 255356c to 061b7fc Compare September 9, 2024 18:29
@aztalbot aztalbot force-pushed the doc/lambda-extensions/cache-header-warning-update branch 12 times, most recently from df5f1eb to 3295761 Compare September 16, 2024 22:46
@aztalbot aztalbot force-pushed the doc/lambda-extensions/cache-header-warning-update branch 4 times, most recently from 0e8c63f to 421dfcb Compare September 19, 2024 00:53
@aztalbot aztalbot force-pushed the doc/lambda-extensions/cache-header-warning-update branch from 421dfcb to 7d0096a Compare September 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants