-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of UI: Fix enabling replication capabilities bug into release/1.17.x #28375
Merged
hashishaw
merged 11 commits into
release/1.17.x
from
backport/ui/VAULT-30458/fix-enabling-replication-capabilities-bug/quickly-improved-amoeba
Sep 20, 2024
Merged
Backport of UI: Fix enabling replication capabilities bug into release/1.17.x #28375
hashishaw
merged 11 commits into
release/1.17.x
from
backport/ui/VAULT-30458/fix-enabling-replication-capabilities-bug/quickly-improved-amoeba
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
September 12, 2024 13:51
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-30458/fix-enabling-replication-capabilities-bug/quickly-improved-amoeba
branch
from
September 12, 2024 13:51
ff8f923
to
a0339d9
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Sep 12, 2024
Build Results: |
CI Results: |
hashishaw
approved these changes
Sep 12, 2024
hashishaw
deleted the
backport/ui/VAULT-30458/fix-enabling-replication-capabilities-bug/quickly-improved-amoeba
branch
September 20, 2024 18:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is a manual fix for the same thing as fixed in #28371. Due to changes in the replication area of the codebase between 1.17 and 1.18, the changes here are specific to 1.17 to minimize the amount of changes going into this release branch.
The below text is copied from the body of the original PR.
Description
A user with the policy below (which is used in this tutorial) was unable to enable replication in the GUI because the UI wasn't checking specifically for
/dr/
or/performance/
in the original capabilities check.Now type is included in the path passed to the capabilities endpoint which hides or shows "Enable" accordingly. If there's a problem reading capabilities, then the default is
true
because the backend can be used as a fallback to gate a user who does not have the correct permissions.I will open a manual backport to address this fix in 1.16 and 1.17 because the capabilities service is new and was added in 1.18
📸 The left is before the fix, and on the right is after.
Both browsers the user is logged in with the policy below.