Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add queries examples #90

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add queries examples #90

wants to merge 3 commits into from
+217 −0

Conversation

motleydev
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Supergraph build was successful! 🎉

Build URLs:

Console URLs:

Commit ID: 4a399f6

typhonius
typhonius requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@typhonius typhonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes noted in the comments. I believe @sandalsoft is going to create a PR with an updated .gitignore that we should piggy-back on.

Would love if the queries directory had a brief README too

.env Outdated Show resolved Hide resolved
.env.local Outdated Show resolved Hide resolved
collibra_import.csv Outdated Show resolved Hide resolved
engine/build/auth_config.json Outdated Show resolved Hide resolved
engine/build/metadata.json Outdated Show resolved Hide resolved
engine/build/open_dd.json Outdated Show resolved Hide resolved
meta.sh Outdated Show resolved Hide resolved
@motleydev
Copy link
Contributor Author

Well, apologies about all the changed files! That was careless on my part. I didn't realize I had some extra cruft in there. I'll take a look at removing the extra files.

@github-actions GitHub Actions
Copy link

Supergraph build was successful! 🎉

Build URLs:

Console URLs:

Commit ID: 04b7c0c

@github-actions GitHub Actions
Copy link

Supergraph build was successful! 🎉

Build URLs:

Console URLs:

Commit ID: dc51ae9

@motleydev
Copy link
Contributor Author

@typhonius What's the goal of an additional readme? It's documented in the wiki, but I'd almost rather have some kind of script invoke these queries with ddn run --file.gql or something and then it makes sense to document. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhonius typhonius typhonius requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motleydev @typhonius