dventimihasura/add-calcite : working on publishing Ken's calcite connector : DO NOT MERGE #284
Conversation
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
dventimihasura
had a problem deploying
to
staging
GitHub Actions
Failure
registry/hasura/cassandra/README.md
Outdated
|
|
||
| ### Update Connector, Track Models and Build | ||
|
|
||
| At this point you can either run the [dev](https://hasura.io/docs/3.0/cli/commands/dev/) mode to watch your project and create new builds as changes are made to your metadata using [Hasura’s LSP](https://hasura.io/docs/3.0/glossary/#lsp-language-server-protocol) and [VSCode extension](https://marketplace.visualstudio.com/items?itemName=HasuraHQ.hasura). |
There was a problem hiding this comment.
The ddn dev command is now outdated
There was a problem hiding this comment.
@codingkarthik rewrote the README by copying the README from ndc-mongodb (which is pretty much boilerplate) and replacing mongodb -> cassandra. This got rid of the reference to ddn dev.
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "version": "1.0.0", | |||
| "uri": "https://github.com/hasura/ndc-cassandra/releases/download/v1.0.0/connector-definition.tgz", | |||
There was a problem hiding this comment.
@dventimihasura The docker image present in this file is docker.io/kstott/meta_connector:cb76d3d-dirty. Usually, we push the connector docker images to Hasura's connector container registry in GHCR (Github container registry). For example, the azure cosmos connector's docker image is ghcr.io/hasura/ndc-azure-cosmos:v0.1.6, if you can do that for Cassandra also it will be great!
There was a problem hiding this comment.
@codingkarthik Replaced kstott -> ghcr.io/hasura everywhere, including in the connector definition that's pointed to here (in a new release v1.0.1)
There was a problem hiding this comment.
Could you please name this file to logo.png ? This is because the publication automation process only picks up the logo file if it is logo.png / logo.svg
1. Removed reference to `ddn dev` from README.md 2. Renamed logo-white-r.png to logo.png 3. Replaced connector defintion with one pointing to ndc-cassandra release v1.0.1 - Replaced kstott with ghcr.io/hasura
dventimihasura
temporarily deployed
to
staging
GitHub Actions
Inactive
dventimihasura
temporarily deployed
to
staging
GitHub Actions
Inactive
dventimihasura
temporarily deployed
to
staging
GitHub Actions
Inactive
No description provided.