feat: support azure blob storage (#3)

.env

@@ -8,4 +8,9 @@ S3_SECRET_ACCESS_KEY=randomsecret
 S3_DEFAULT_BUCKET=bucket1
 
 APP_STORAGE_READ_URL="http://local.hasura.dev:8080"
-APP_STORAGE_WRITE_URL="http://local.hasura.dev:8080"
+APP_STORAGE_WRITE_URL="http://local.hasura.dev:8080"
+
+AZURE_STORAGE_ENDPOINT=http://local.hasura.dev:10000
+AZURE_STORAGE_DEFAULT_BUCKET=azure-test
+AZURE_STORAGE_ACCOUNT_NAME=local
+AZURE_STORAGE_ACCOUNT_KEY=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==

.golangci.yml

@@ -29,8 +29,6 @@ linters-settings:
     skip-tests: true
 
   dupl:
-    # Tokens count to trigger issue.
-    # Default: 150
     threshold: 200
 
   nestif:
@@ -44,12 +42,8 @@ linters-settings:
     excludes:
       - G115
       - G306
-
-  #   gocritic:
-  #     disabled-checks:
-  #       - appendAssign
-  #   gocyclo:
-  #     min-complexity: 40
+      - G401
+      - G501
 
   revive:
     max-open-files: 2048

.vscode/settings.json

@@ -0,0 +1,5 @@
+{
+  "cSpell.words": [
+    "azblob"
+  ]
+}

README.md

@@ -17,6 +17,7 @@ At this moment, the connector supports S3 Compatible Storage services.
 | Google Cloud Storage | ✅        |
 | Cloudflare R2        | ✅        |
 | DigitalOcean Spaces  | ✅        |
+| Azure Blob Storage   | ✅        |
 
 ## Get Started
 
@@ -27,7 +28,7 @@ The connector is built upon the MinIO Go Client SDK so it supports most of metho
 ## Documentation
 
 - [Configuration](./docs/configuration.md)
-- [Upload/Download Objects](./docs/upload-download.md)
+- [Manage Objects](./docs/objects.md)
 
 ## License
 

compose.yaml

@@ -21,6 +21,11 @@ services:
       S3_DEFAULT_BUCKET: $S3_DEFAULT_BUCKET
       S3_ACCESS_KEY_ID: $S3_ACCESS_KEY_ID
       S3_SECRET_ACCESS_KEY: $S3_SECRET_ACCESS_KEY
+      AZURE_STORAGE_ENDPOINT: $AZURE_STORAGE_ENDPOINT
+      AZURE_STORAGE_CONNECTION_STRING: DefaultEndpointsProtocol=http;AccountName=${AZURE_STORAGE_ACCOUNT_NAME};AccountKey=${AZURE_STORAGE_ACCOUNT_KEY};BlobEndpoint=${AZURE_STORAGE_ENDPOINT}
+      AZURE_STORAGE_DEFAULT_BUCKET: $AZURE_STORAGE_DEFAULT_BUCKET
+      AZURE_STORAGE_ACCOUNT_NAME: $AZURE_STORAGE_ACCOUNT_NAME
+      AZURE_STORAGE_ACCOUNT_KEY: $AZURE_STORAGE_ACCOUNT_KEY
       HASURA_LOG_LEVEL: debug
       OTEL_EXPORTER_OTLP_ENDPOINT: http://otel-collector:4317
       OTEL_METRICS_EXPORTER: prometheus
@@ -51,6 +56,18 @@ services:
     volumes:
       - s3_data:/containers3root
 
+  # https://github.com/Azure/Azurite
+  azurite:
+    image: mcr.microsoft.com/azure-storage/azurite
+    restart: always
+    command: ["azurite-blob", "--blobHost", "0.0.0.0", "-d", "/debug.log"]
+    extra_hosts:
+      - local.hasura.dev=host-gateway
+    ports:
+      - "10000:10000"
+    environment:
+      AZURITE_ACCOUNTS: "${AZURE_STORAGE_ACCOUNT_NAME}:${AZURE_STORAGE_ACCOUNT_KEY}"
+
 volumes:
   minio_data:
   s3_data:

configuration/update.go

@@ -9,6 +9,8 @@ import (
 
 	"github.com/hasura/ndc-sdk-go/utils"
 	"github.com/hasura/ndc-storage/connector/storage"
+	"github.com/hasura/ndc-storage/connector/storage/common"
+	"github.com/hasura/ndc-storage/connector/storage/minio"
 	"github.com/hasura/ndc-storage/connector/types"
 	"gopkg.in/yaml.v3"
 )
@@ -63,13 +65,11 @@ var defaultConfiguration = types.Configuration{
 	},
 	Clients: []storage.ClientConfig{
 		{
-			Type: storage.EnvStorageProviderType{
-				EnvString: utils.NewEnvStringVariable("STORAGE_PROVIDER_TYPE"),
-			},
-			Endpoint:      utils.ToPtr(utils.NewEnvStringVariable("STORAGE_ENDPOINT")),
-			DefaultBucket: utils.NewEnvStringVariable("DEFAULT_BUCKET"),
-			Authentication: storage.AuthCredentials{
-				Type:            storage.AuthTypeStatic,
+			"type":          common.S3,
+			"endpoint":      utils.ToPtr(utils.NewEnvStringVariable("STORAGE_ENDPOINT")),
+			"defaultBucket": utils.NewEnvStringVariable("DEFAULT_BUCKET"),
+			"authentication": minio.AuthCredentials{
+				Type:            minio.AuthTypeStatic,
 				AccessKeyID:     utils.ToPtr(utils.NewEnvStringVariable("ACCESS_KEY_ID")),
 				SecretAccessKey: utils.ToPtr(utils.NewEnvStringVariable("SECRET_ACCESS_KEY")),
 			},

connector-definition/configuration.yaml

@@ -1,7 +1,7 @@
 # yaml-language-server: $schema=https://raw.githubusercontent.com/hasura/ndc-storage/main/jsonschema/configuration.schema.json
 clients:
-  - type:
-      env: STORAGE_PROVIDER_TYPE
+  - id: default
+    type: s3
     endpoint:
       env: STORAGE_ENDPOINT
     defaultBucket:
@@ -19,4 +19,4 @@ clients:
     allowedBuckets: []
 concurrency:
   query: 5
-  mutation: 1
+  mutation: 3