Feat UI tweaks #1315
Feat UI tweaks #1315
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
requested review from
abelanger5 and
mrkaye97
and removed request for
abelanger5
|
I think we should consider a more aggressive revision for some of these things at some point... but just want to get these working changes in |
| import { Button } from '@/components/ui/button'; | ||
|
|
||
| export interface BannerProps { | ||
| message: React.ReactNode; |
There was a problem hiding this comment.
qq: can we make this a string?
There was a problem hiding this comment.
i think we may want to include an icon or additional links here (i.e. link to migration docs)
| showBanner?: boolean; | ||
| } | ||
|
|
||
| export const Banner: React.FC<BannerProps> = ({ |
There was a problem hiding this comment.
stylistic nit: I've been defining components like this:
export const Banner = ({foo, bar}: BannerProps) => {}I don't care which we end up going for, but I think we should try to be consistent. WDYT? I kinda like the way I've been doing it because it's a little more terse, but I'm fine either way
There was a problem hiding this comment.
personally prefer React.FC since it adds some additional type safety if needed later
There was a problem hiding this comment.
ah nice, vs. just JSX.Element? sounds good to me
Description
UI Tweaks for upgrade routes