Webpack 4 support #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or..of loop over the modulesIterable object
…ent so that webpack doesn't do aggressive tree-shaking and strip out the module import
of an exclude option. I want to exclude node_modules paths from getting prettified.
|
Hey, thanks for your great work on this! 👏 I see you started a bit of work toward #19 as well; I'd like to keep these efforts separate for now, but I'd love another PR for that so we could back-port it to a webpack < 4 compatible release if you're interested to help out there too! 😄 Current thoughts are:
That said, is there anything else left for Webpack 4 support outstanding with this PR? |
|
I don't think there's anything outstanding for webpack 4 support. I removed the #19 work-in-progress prior to creating this PR, so I think it's ready to go! |
|
Closing for #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31
Upgrade dependencies and support the webpack 4 plugin system. Didn't make any attempt to support earlier versions of webpack (maybe should add webpack ^4.0.0 as a peer dependency?).
Needed to tweak the tests to get them to pass, and needed to update the jest configuration slightly.