adjust key computation to avoid trailing -
#186
Conversation
The `-` suffix was being applied unconditionally resulting in a hanging `-` suffix if no timestamp was used. Adjust the key computation to remove the trailing `-` if no timestamp is used.
|
The change also affects restore keys. I am a bit afraid of unwanted side effects. It looks like a breaking change at the moment. What about only removing the |
Hmm, this was the effect that I was going for. Perhaps I misunderstood the code and did something incorrectly for accomplishing the desired effect?
That does still add a suffix which does make it harder to find the cache entry when you have a number of them unfortunately :(. |
| const primaryKey = inputs.primaryKey ? keyPrefix + inputs.primaryKey + "-" : keyPrefix; | ||
| const restoreKeys = inputs.restoreKeys.map(k => keyPrefix + k + "-") | ||
| const primaryKey = inputs.primaryKey ? ccacheVariant + "-" + inputs.primaryKey : ccacheVariant; | ||
| const restoreKeys = inputs.restoreKeys.map(k => ccacheVariant + "-" + k) |
There was a problem hiding this comment.
the concrete line I talk about. I understand that before the change the restore key is:
"ccache-{k}-"
after
"ccache-{k}"
There was a problem hiding this comment.
Right, so, I made that change because I changed the save key. If that change is not needed, I'm totally happy to undo it. Maybe I didn't fully grok how the save/restore keys work.
The
-suffix was being applied unconditionally resulting in a hanging-suffix if no timestamp was used. Adjust the key computation to remove the trailing-if no timestamp is used.