Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction mode #503

Open
wants to merge 26 commits into
base: united
Choose a base branch
from
Open

Instruction mode #503

wants to merge 26 commits into from

Conversation

ebolam
Copy link

@ebolam ebolam commented Jan 28, 2024

Working instruction mode.

Some design decisions in the UI to highlight:

  • A single action may contain BOTH game text and an instruction
  • Instructions may be hidden globally in case the user is writing a story and wants to use them for guidance instead of story
  • Instruction Header/Footer is saved with the model, not the story/user/system
  • Global hide instructions is tied to the user (May want to in the future have a default tied to the user with actual setting tied to the story)
  • Allows for ctrl+a delete, or large area text selection and re-write (with instructions covered in the selection area)
  • Does not visually replace instruction header/footer with [{{INPUT}}]/[{{OUTPUT}}]. Backend does save with those tags.
  • Other than deleting the whole chunk, instruction headers/footers cannot be edited.
  • The above CAN cause issues with selecting the end of the instruction user input as the footer starts right after the last character...
  • UI puts instructions in a div. This forces the instruction onto it's own line(s). Those are tagged in CSS for theming (default top/bottom borders).
  • UI puts instruction headers/footers and instruction user input into their own classes so they can be colored in themes (default header/footer to a dark grey to show it can't be edited)

@ebolam
Copy link
Author

ebolam commented Jan 29, 2024

Found bug where the instruction mode css tags get messed up if the instruction contains world info tags.

…al word.

Add in ... underline on newest text to make reading new text easier (theme-able)
…de text.

Needs testing for instruction mode but should be the same as last code other than visually.
@ebolam
Copy link
Author

ebolam commented Feb 14, 2024

Bug for instruction mode bug with world info above is now fixed. Reworked world info matching in the UI as well which works better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant