-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce ghostscript for heroku-24 #324
Conversation
Does the APT buildpack work for installing ghostscript? |
In my testing (with CNBs), no. If we would rather make |
Checking against the nightly image tag (since that has #321), the size impact of adding Ghostscript isn't as bad as I would have thought (albeit it still is +10%):
And ...so we don't need to explicitly include |
Fwiw I'd be fine with either adding back |
The full
Though, If we want to support installation via the Debian packages CNB, we'd need to add |
Hmm yeah so adding Though long long term, if we introduce a slim image, I suppose we'll want to update the Debian packages CNB to set |
Tried installing |
b879762
to
68d3a73
Compare
It's now already included after the recent re-introduction of ghostscript in #324
* Add some missing runtime libraries to heroku-22 - libgeoip1 because of libgeoip-dev - libhashkit2 because of libhashkit-dev - libmemcachedutil2 because of libmemcached-dev - libnetpbm10 because of libnetpbm10-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871 * Add some missing runtime libraries to heroku-24 - libgirepository-1.0-1 because of libgirepository1.0-dev and libgirepository-1.0-dev - libidn12 because of libidn-dev - libmemcachedutil2t64 because of libmemcached-dev - libwebpdecoder3 because of libwebp-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871 * Remove explicit libidn12 install from heroku-24 again It's now already included after the recent re-introduction of ghostscript in #324 * Drop libgeoip1 from heroku-22 again As discussed in #317, we removed this from heroku-24, and it hasn't come up as an issue report. * Drop libgirepository-1.0-1 amd64-only install from heroku-24 again As discussed in #317
Hi, this is effecting me, can anyone say if it's available on heroku-24 publicly yet, or if not expected timeline? Thank you! |
@jrochkind Hi! This was released in https://github.com/heroku/base-images/releases/tag/v135 which was rolled out to the Common Runtime on Sept 24/25th (and checking Private Spaces deployments, rollout there finished ~29th): eg:
|
thanks very much for this! |
* Reintroduce ghostscript for heroku-24 * Update installed-packages lists for heroku-24 w/ ghostscript
* Add some missing runtime libraries to heroku-22 - libgeoip1 because of libgeoip-dev - libhashkit2 because of libhashkit-dev - libmemcachedutil2 because of libmemcached-dev - libnetpbm10 because of libnetpbm10-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871 * Add some missing runtime libraries to heroku-24 - libgirepository-1.0-1 because of libgirepository1.0-dev and libgirepository-1.0-dev - libidn12 because of libidn-dev - libmemcachedutil2t64 because of libmemcached-dev - libwebpdecoder3 because of libwebp-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871 * Remove explicit libidn12 install from heroku-24 again It's now already included after the recent re-introduction of ghostscript in #324 * Drop libgeoip1 from heroku-22 again As discussed in #317, we removed this from heroku-24, and it hasn't come up as an issue report. * Drop libgirepository-1.0-1 amd64-only install from heroku-24 again As discussed in #317
We've received some feedback about ghostscript (which was included in Heroku-18, Heroku-20, and Heroku-22, but was not included in Heroku-24):
So, while not being used directly a ton, folks do use ghostscript via ImageMagick to work with PDFs.
Other packages we could consider:- libgs10- gsfontsGUS