Move heroku/nodejs group to the end

[dzuelke]

Apps written in other languages often have a package.json, and the current order causes these to be detected as a Node.js codebase.

N.b. the diff for heroku-20 is just a bit funky looking, it's really the same as for the two others when you look at it with git diff --patience:

diff --git a/builder-20/builder.toml b/builder-20/builder.toml
index 097d01f..c09b53c 100644
--- a/builder-20/builder.toml
+++ b/builder-20/builder.toml
@@ -89,18 +89,6 @@ version = "0.20.1"
     id = "heroku/eol-warning"
     version = "1.0.0"
 
-[[order]]
-  [[order.group]]
-    id = "heroku/nodejs"
-    version = "3.2.13"
-  [[order.group]]
-    id = "heroku/procfile"
-    version = "3.1.2"
-    optional = true
-  [[order.group]]
-    id = "heroku/eol-warning"
-    version = "1.0.0"
-
 [[order]]
   [[order.group]]
     id = "heroku/java"
@@ -148,3 +136,16 @@ version = "0.20.1"
   [[order.group]]
     id = "heroku/eol-warning"
     version = "1.0.0"
+
+# this group is intentionally at the end, because projects in other languages often have e.g. a package.json
+[[order]]
+  [[order.group]]
+    id = "heroku/nodejs"
+    version = "3.2.13"
+  [[order.group]]
+    id = "heroku/procfile"
+    version = "3.1.2"
+    optional = true
+  [[order.group]]
+    id = "heroku/eol-warning"
+    version = "1.0.0"

GUS-W-16712980

[joshwlewis]

I have no issues with moving Node.js to the end. I think most specific to least specific is a pretty good strategy that the Node.js buildpack uses to resolve package manager selection, and I think it makes sense for language selection too.

However -- couldn't this also be solved by adding an optional heroku/nodejs to the heroku/php group? Basically, solve this the way heroku/ruby is?

[dzuelke]

The issue is that for many of these projects, there is no lock file for package.json, so the build would fail - a new Laravel framework skeleton project, for example.