Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Heroku-18 support #117

Merged
merged 1 commit into from
Nov 7, 2023
Merged

remove Heroku-18 support #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
build: build-heroku-18 build-heroku-20 build-heroku-22

build-heroku-18:
@echo "Building nginx in Docker for heroku-18..."
@docker run -v $(shell pwd):/buildpack --rm -it -e "STACK=heroku-18" -w /buildpack heroku/heroku:18-build scripts/build_nginx /buildpack/nginx-heroku-18.tgz
build: build-heroku-20 build-heroku-22

build-heroku-20:
@echo "Building nginx in Docker for heroku-20..."
Expand Down
4 changes: 4 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [unlreleased] - XXXX-XX-XX
### Changes
- [heroku-18] Removed

## [1.10] - 2023-06-13
### Changes
- New "Static site" preset config
Expand Down
Binary file removed nginx-heroku-18.tgz
View file
Open in desktop
Binary file not shown.
3 changes: 1 addition & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ These are auto-selected based on the app's stack at build time.

| Heroku Stack | Nginx Version |
|--------------|--------------:|
| `Heroku-18` | `1.25.1` |
| `Heroku-20` | `1.25.1` |
| `Heroku-22` | `1.25.1` |

Expand All @@ -39,7 +38,7 @@ _Proxy is the original buildpack mode that is enabled by default, if the `config

### Solo mode (deprecated)

This mode has been superceeded by [Static mode](static.md).
This mode has been superceeded by [Static mode](static.md).

## Custom Nginx usage

Expand Down