Use the web_url to ensure we use the new domain names #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
added
the
skip changelog
colincasey
reviewed
Jun 20, 2023
colincasey
reviewed
Jun 20, 2023
colincasey
approved these changes
Jun 20, 2023
ostenbom
pushed a commit
to mentimeter/heroku-buildpack-nodejs
that referenced
this pull request
Sep 11, 2023
* Use the web_url to ensure we use the new domain names * Fetch web_url from platform_api * platform_api isn't private, so no need for send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has been failing (example: https://github.com/heroku/heroku-buildpack-nodejs/actions/runs/5314918171/jobs/9638438314) due to the hatchet tests assuming an app's
web_urlto be#{app_name}.herokuapp.com. That's not always the case anymore. See the Heroku changelog entry that describes the new naming scheme: https://devcenter.heroku.com/changelog-items/2640.