-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for heroku-24 #1243
Conversation
strategy: | ||
matrix: | ||
stack_number: ["20", "22"] | ||
stack_number: ["20", "22", "24"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst approving/merging #1248 I noticed that the new Heroku-24 test jobs in the matrix weren't marked as required for branch protection (along with the "Test Metrics (14.10.0)" job too). I've added them to the required list now:
https://github.com/heroku/heroku-buildpack-nodejs/settings/branch_protection_rules/17110526
This adds heroku-24 to the testing matrix. Happily, all the tests pass without modification.