Export NODE_OPTIONS env default to downstream buildpacks
#1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has not set a custom
NODE_OPTIONSenvironment variable, we automatically setNODE_OPTIONS="--max_old_space_size=2560"in the build environment. This setting helps to mitigate OOM issues that sometimes occur when asset compilation tools are used.This setting is currently limited to the Node.js Buildpack's environment. To propagate this setting to downstream buildpacks such as the Ruby Buildpack (which sometimes requires Node to run asset compilation tasks too), this PR writes the setting to the
<buildpack_dir>/exportfile. It will not export the setting if the user already has a customNODE_OPTIONSenvironment variable.