Improved CI package manager detection #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method for detecting package managers works well when `yarn`, `pnpm`, or `npm` binaries are installed in the traditional way but fails when `corepack` shims are present. This PR changes the detection logic to use package metadata when determining which package manager to use.
The previous method for detecting package managers works well when `yarn`, `pnpm`, or `npm` binaries are installed in the traditional way but fails when `corepack` shims are present. This PR changes the detection logic to use package metadata when determining which package manager to use.
joshwlewis
reviewed
Aug 29, 2024
joshwlewis
approved these changes
Aug 29, 2024
colincasey
added a commit
that referenced
this pull request
Sep 4, 2024
Along with lockfile detection, we also detect what intended package manager (and version) should be used based on metadata found in package.json. When multiple package managers are declared we should fail the build early and ask the user to correct any conflicts found. Related to #1313
colincasey
added a commit
that referenced
this pull request
Sep 4, 2024
Along with lockfile detection, we also detect what intended package manager (and version) should be used based on metadata found in package.json. When multiple package managers are declared we should fail the build early and ask the user to correct any conflicts found. Related to #1313
Merged
colincasey
added a commit
that referenced
this pull request
Sep 11, 2024
* Fail on conflicting package manager metadata in package.json Along with lockfile detection, we also detect what intended package manager (and version) should be used based on metadata found in package.json. When multiple package managers are declared we should fail the build early and ask the user to correct any conflicts found. Related to #1313 * Fail on conflicting package manager metadata in package.json Along with lockfile detection, we also detect what intended package manager (and version) should be used based on metadata found in package.json. When multiple package managers are declared we should fail the build early and ask the user to correct any conflicts found. Related to #1313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method for detecting package managers works well when
yarn,pnpm, ornpmbinaries are installed in the traditional way but fails whencorepackshims are present. This PR changes the detection logic to use package metadata when determining which package manager to use.Fixes #1312