Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js Engine Inventory #1323

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

heroku-linguist[bot]
Copy link
Contributor

Automated pull-request to update heroku/nodejs engine inventory:

  • Added Node.js version 22.9.0.

- Added Node.js version 22.9.0.
@heroku-linguist heroku-linguist bot enabled auto-merge (squash) September 18, 2024 04:03
@heroku-linguist heroku-linguist bot merged commit dcaeff5 into main Sep 20, 2024
11 checks passed
@heroku-linguist heroku-linguist bot deleted the update-nodejs-inventory branch September 20, 2024 14:35
@jraoult
Copy link

jraoult commented Sep 20, 2024

@colincasey I had a situation where my automated dependency updates bot was too fast to upgrade to Node v22.9. My checks passed in CI (GitHub actions), but when deployed to Heroku, the build pack couldn't find the Node version, and our staging environment failed to build. That's what staging is for, but I'd rather avoid auto-merging a node upgrade that could break the build once it is deployed in Heroku.

I could enforce a longer delay before the bot tries to upgrade the Node version (currently set to 3 days). So, what's the typical delay between a Node release and the time the update to the "inventory" is merged and released? Alternatively, is there a way to "pre-check" that a particular app will be successfully built?

@heroku-linguist heroku-linguist bot mentioned this pull request Sep 20, 2024
@colincasey
Copy link
Contributor

Hi @jraoult, sorry to hear the delay in getting this buildpack released has caused you trouble. I do try my best to publish this buildpack within 1 day of new Node.js releases but, as is the way with most things, sometimes external factors get in the way. Case in point, I won't be able to release the recent changes for this buildpack until Monday (Sept. 23rd).

If this is currently blocking you, what you can do instead of waiting for the official release is (temporarily) replace the heroku/nodejs buildpack in your app's buildpack list with https://github.com/heroku/heroku-buildpack-nodejs#latest which will load the buildpack directly from GitHub.

As for the most reliable way you could "pre-check" if the latest Node.js version would successfully build on Heroku is by using a Review App.

@jraoult
Copy link

jraoult commented Sep 21, 2024

@colincasey no worries. I just rolled back the automated upgrade.

Heroku is by using a Review App.

We used to have auto Review App creation for every PR. Still, we realised it wasn't blocking the PR auto-merge in some situations because the other checks would finish before the review even added time to start building—sort of a race condition. I need to look at that again and see if there is a way to make it work. In the meantime, I just disabled auto merge for Node upgrade-related PR so I can manually check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants