Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pruning if NPM_CONFIG_PRODUCTION or YARN_PRODUCTION is defined #529

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Skip pruning if NPM_CONFIG_PRODUCTION or YARN_PRODUCTION is defined #529

merged 1 commit into from
Mar 2, 2018

Conversation

jmorrell
Copy link
Contributor

@jmorrell jmorrell commented Mar 2, 2018

Fixes part of @edmorley's issues in #526 by skipping pruning when NPM_CONFIG_PRODUCTION=true or YARN_PRODUCTION=true since there will be no devDependencies to strip away.

@jmorrell jmorrell requested a review from a team March 2, 2018 22:06
edmorley
edmorley approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for taking a look at this :-)

@jmorrell jmorrell merged commit bd68ebe into master Mar 2, 2018
@jmorrell jmorrell deleted the skip-pruning-for-production-true branch March 2, 2018 22:33
@jmorrell jmorrell mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmorrell @jkutner @edmorley