Add ARM support for NodeJS #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on the format of RUBY_PLATFORM is a little surprising. This allows us to test if we want and reuses the existing architecture logic for consistency.
schneems
force-pushed
the
schneems/arm-nodejs-support
branch
from
938a7f4
to
24e390c
Compare
edmorley
approved these changes
Oct 8, 2024
Co-authored-by: Ed Morley <[email protected]>
Closed
chaadow
reviewed
Oct 12, 2024
| it "should extract a node binary on #{arch}" do | ||
| Dir.mktmpdir do |dir| | ||
| Dir.chdir(dir) do | ||
| installer = LanguagePack::Helpers::NodeInstaller.new(arch: "arm64") |
There was a problem hiding this comment.
I think this should be: installer = LanguagePack::Helpers::NodeInstaller.new(arch: arch) and not hardcode arm64
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #1493