Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use generic request for all List calls #616

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Mar 12, 2025

Uses the new generic requests function to reduce the code duplication for the List calls.

@jooola jooola requested a review from a team as a code owner March 12, 2025 12:07
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (3c3d2e4) to head (97a0459).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   67.74%   68.07%   +0.32%     
==========================================
  Files          48       49       +1     
  Lines        5020     4886     -134     
==========================================
- Hits         3401     3326      -75     
+ Misses       1198     1159      -39     
+ Partials      421      401      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a review myself, and looks good :)

@jooola jooola merged commit 244c673 into main Mar 12, 2025
6 checks passed
@jooola jooola deleted the generic-List branch March 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants