Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use generic request for GetByName calls #618

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Mar 12, 2025

Uses the new generic requests function to reduce the code duplication for the GetByName calls (and others similar functions).

@jooola jooola requested a review from a team as a code owner March 12, 2025 14:12
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (0d190e7) to head (ba507c8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   70.28%   69.78%   -0.50%     
==========================================
  Files          49       49              
  Lines        4667     4591      -76     
==========================================
- Hits         3280     3204      -76     
  Misses       1023     1023              
  Partials      364      364              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola force-pushed the generic-GetByName branch from 5a4931e to ba507c8 Compare March 12, 2025 14:37
@jooola jooola merged commit 884d89a into main Mar 12, 2025
6 checks passed
@jooola jooola deleted the generic-GetByName branch March 12, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants