Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use correct response schema #632

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Mar 19, 2025

This does not include the fixes for the primary ip client, because those changes are more involved.

Related to the comments in #624

@jooola jooola requested a review from a team as a code owner March 19, 2025 10:28
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (62ecd3e) to head (306a4d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   78.87%   78.71%   -0.17%     
==========================================
  Files          50       50              
  Lines        4359     4359              
==========================================
- Hits         3438     3431       -7     
- Misses        706      711       +5     
- Partials      215      217       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola merged commit 786f18a into main Mar 19, 2025
6 checks passed
@jooola jooola deleted the invalid_response_schemas branch March 19, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants