Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for adding external scripts to document. #300

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for adding external scripts to document. #300

wants to merge 3 commits into from

Commits on May 29, 2022

  1. Add support for adding external scripts to document. 

    This PR adds support for adding external scripts to the document.

Not sure if the way that I implemented 'attributes' to the
AddScript function is the most convinent. Let me know what solution
could fit better.

Created tests for AddScript function.
    @ferealqq
    ferealqq committed May 29, 2022
    Configuration menu
    Copy the full SHA
    aa1384f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. AddScript guarntees that the script was loaded. 

    AddScript guarntees that the script was loaded or returns a error.
    @ferealqq
    ferealqq committed May 30, 2022
    Configuration menu
    Copy the full SHA
    bd572ab View commit details
    Browse the repository at this point in the history

  2. AddScript removeEventListener when returning 

    AddScript removes "onload" event listener when the function
has executed.
    @ferealqq
    ferealqq committed May 30, 2022
    Configuration menu
    Copy the full SHA
    f839ebd View commit details
    Browse the repository at this point in the history