Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

bump to holochain 0.3.0-dev.34 #219

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

matthme
Copy link
Collaborator

@matthme matthme commented Apr 6, 2024

No description provided.

@matthme matthme requested a review from c12i April 6, 2024 16:28
@matthme
Copy link
Collaborator Author

matthme commented Apr 7, 2024

Note that the failing test is only for the launcher tauri front-end which is not actively maintained anymore.

@@ -21,7 +22,7 @@ use crate::prepare_webapp;
use holochain_cli_sandbox::cmds::{Create, Existing, NetworkCmd, NetworkType};

#[derive(Debug, Parser)]
#[command(version = "0.0.14 (holochain 0.3.0-beta-dev.34)")]
#[command(version = "0.300.0-dev.0 (holochain 0.3.0-beta-dev.44)")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the version inferred from the version in Cargo.toml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be inferred from the Cargo.toml as well I think yes but (at the time I wrote that part of the code) I thought it's valuable to have the compatible holochain version displayed there as well which cannot be inferred otherwise. Since I just switched to using version bucketing that might become obsolete though since compatibility with 0.3.x is now implied in the version number. So maybe I shuold switch to taking it from Cargo.toml now...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will switch to taking the version from Cargo.toml once holochain 0.3.0 is out, until then it's useful to know which verison exactly hc launch is compatible with since there are still breaking changes in holochain ahead I think.

@matthme matthme merged commit 36fbe8b into holochain-weekly Apr 8, 2024
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants