Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hvPlotAgent as default #740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add hvPlotAgent as default #740

wants to merge 2 commits into from

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Oct 29, 2024

Initially I thought there was a bug with initializing a list of agents #739

Then, I was surprised to find that it was not in the default agents given that Lumen is a data viz library (I think?) and depends on hvplot https://github.com/holoviz/lumen/blob/main/pyproject.toml#L31

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.22%. Comparing base (049a997) to head (b57f357).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   61.22%   61.22%           
=======================================
  Files         101      101           
  Lines       12352    12352           
=======================================
  Hits         7562     7562           
  Misses       4790     4790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

The thing here is that both hvPlot and Vega are good choices and in my testing I've found the vega agent more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants