-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vesync debug mode in library #134571
Merged
Merged
Add vesync debug mode in library #134571
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8d9815f
Debug mode pass through
cdnninja 81373d0
Correct code, shouldn't have been lambda
cdnninja afb829a
listener for change
cdnninja 0337b4a
Merge branch 'dev' into enableDebug
cdnninja 98b35c4
ruff
cdnninja b92b0f4
Update manifest.json
cdnninja 0d8373c
Reflect correct logger title
cdnninja ab997f5
Merge branch 'dev' into enableDebug
cdnninja 2d2abb6
Merge branch 'dev' into enableDebug
cdnninja f796cc0
Merge branch 'dev' into enableDebug
cdnninja 1a9e0b4
Ruff fix from merge
cdnninja c49f7c1
Merge branch 'dev' into enableDebug
cdnninja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't the library use the standard Python logging mechanism and best practice with just using a logger per module or package? Why does it need this attribute on the manager?
Eg:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just how it was written - as webdjoe mentioned a re-write of the library is coming that will solve this. If we merge this current code it gives us debug ability until that happens.
It would get removed on the re-write update.