Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant parameter from config_entry data of LCN integration #135912

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

alengwenus
Copy link
Contributor

Proposed change

The current config_entry.data for the LCN integration holds two parameters: domain_data and resource.
The resource parameter can be calculated only from the domain_data and is therefore redundant.

With this PR, the resource parameter is removed from config_entry.data and dynamically calculated where needed.
In addition, the resource parameter for the climate and scene platforms were overdetermined. This will also be fixed in this context.

The resource parameter is also included in the determination of the unique entity id, this also needs migration.

The resource parameter was also passed to the frontend panel. This is replaced by the domain_data parameter. So this dependency needs an update as well:
lcn-frontend (0.2.3):
Release notes: https://github.com/alengwenus/lcn-frontend/releases
Code changes: alengwenus/lcn-frontend@0.2.3...0.2.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@alengwenus alengwenus marked this pull request as draft January 18, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant