Remove redundant parameter from config_entry data of LCN integration #135912
+350
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The current
config_entry.data
for the LCN integration holds two parameters:domain_data
andresource
.The
resource
parameter can be calculated only from thedomain_data
and is therefore redundant.With this PR, the
resource
parameter is removed fromconfig_entry.data
and dynamically calculated where needed.In addition, the
resource
parameter for the climate and scene platforms were overdetermined. This will also be fixed in this context.The
resource
parameter is also included in the determination of the unique entity id, this also needs migration.The
resource
parameter was also passed to the frontend panel. This is replaced by thedomain_data
parameter. So this dependency needs an update as well:lcn-frontend (0.2.3):
Release notes: https://github.com/alengwenus/lcn-frontend/releases
Code changes: alengwenus/lcn-frontend@0.2.3...0.2.4
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: