Do not base power switch state on appliance's operation state at Home Connect #135932
+0
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Simplifícate how the state of the power switch is determined by removing unnecessary functionality.
Type of change
Additional information
I don't know what is the reason behind using the appliance's operation state to determine if the appliance is on or off.
If the appliance cannot report on or off, the user will know it and can use the operation state to make automations.
I think that entities states should not be based on other values unless a good reason, which I think is missing in this case as this was added with the first commit (even in the very first commit at #29214 (95aca52)) of this integration and was not reasoned.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: