Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump intents to 2025.3.12 #140896

Closed

Conversation

staticdev
Copy link

@staticdev staticdev commented Mar 18, 2025

Breaking change

None described on release notes.

Proposed change

Bump intents used on voice assistant to 2025.3.12.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft March 18, 2025 22:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@staticdev staticdev force-pushed the bump/intents-2025.3.12 branch from 4bc13b4 to c12b07a Compare March 19, 2025 19:09
@staticdev
Copy link
Author

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Dear @frenck, thank you very much for your review:

@frenck
Copy link
Member

frenck commented Mar 19, 2025

Please adjust the PR description as requested.

@frenck frenck marked this pull request as draft March 19, 2025 21:44
@frenck frenck removed their request for review March 19, 2025 21:44
@staticdev staticdev force-pushed the bump/intents-2025.3.12 branch from 74c9f53 to 929de59 Compare March 19, 2025 21:51
@staticdev staticdev marked this pull request as ready for review March 19, 2025 21:51
@home-assistant home-assistant bot requested a review from frenck March 19, 2025 21:51
@staticdev
Copy link
Author

staticdev commented Mar 19, 2025

@frenck added in the Description in Additional information.

@staticdev staticdev force-pushed the bump/intents-2025.3.12 branch from 929de59 to 25c4dff Compare March 21, 2025 06:46
@staticdev
Copy link
Author

@synesthesiam could you also please take a look?

@synesthesiam
Copy link
Contributor

@staticdev I appreciate the effort, but I'm planning on a new release again soon so I'll bump it then.

Was there something specific you were after in this release?

@staticdev
Copy link
Author

@synesthesiam I am basically wanting to retrest pt-br blnds intents I chenged.
Also there is a user waiting home-assistant/intents#2988
I saw you did a major version of hassil, but not sure what is needed on intents side.

@synesthesiam
Copy link
Contributor

Bumping to more recent release here: #141241

@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants