-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: middleware for compatibility with express/connect for Hono #928
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b393f28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hi @yusukebe There are two problems with this implementation. The first is regarding the header update process. This test fails. Here is the cause. The header is not removed successfully. |
Second, even using “next” internally does not count as Hono's overall middleware. However, this problem can be sufficiently avoided by being careful about the order of execution. (It is obvious that the performance is quite bad) |
ToDo: mark as dev deps |
Co-Authored-By: sor4chi ([email protected])
Hi @EdamAme-x I think this approach is okay (actually, there is only this way), though the overheads are heavy as you said. I'll check the problems. |
resolve: honojs/hono#3293
Still some concerns and bugs.
The author should do the following, if applicable
yarn changeset
at the top of this repo and push the changeset