feat(ssg): make it more polite

honojs · Feb 16, 2024 · b26b2fb · b26b2fb
1 parent 810b53e
commit b26b2fb
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 4 deletions.
diff --git a/packages/ssg/src/ssg.ts b/packages/ssg/src/ssg.ts
@@ -13,6 +13,9 @@ export const defaultOptions: Required<SSGOptions> = {
 }
 
 export const ssgBuild = (options?: SSGOptions): Plugin => {
+  const virtualId = 'virtual:ssg-void-entry'
+  const resolvedVirtualId = '\0' + virtualId
+
   const entry = options?.entry ?? defaultOptions.entry
   let config: ResolvedConfig
   return {
@@ -22,20 +25,30 @@ export const ssgBuild = (options?: SSGOptions): Plugin => {
       return {
         build: {
           rollupOptions: {
-            input: [entry],
+            input: [virtualId],
           },
         },
       }
     },
     configResolved(resolved) {
       config = resolved
     },
+    resolveId(id) {
+      if (id === virtualId) {
+        return resolvedVirtualId
+      }
+    },
     load(id) {
-      // discard entry file content
-      return 'export default {};'
+      if (id === resolvedVirtualId) {
+        return ''
+      }
     },
     async generateBundle(_outputOptions, bundle) {
-      for (const key in bundle) delete bundle[key]
+      for (const chunk of Object.values(bundle)) {
+        if (chunk.type === 'chunk' && chunk.moduleIds.includes(resolvedVirtualId)) {
+          delete bundle[chunk.fileName]
+        }
+      }
 
       // Create a server to load the module
       const server = await createServer({

diff --git a/packages/ssg/test/ssg.test.ts b/packages/ssg/test/ssg.test.ts
@@ -37,4 +37,37 @@ describe('ssgPlugin', () => {
     const output = fs.readFileSync(outputFile, 'utf-8')
     expect(output).toBe('<html><body><h1>Hello!</h1></body></html>')
   })
+
+  it('Should keep other inputs politely', async () => {
+    expect(fs.existsSync(entryFile)).toBe(true)
+
+    await build({
+      plugins: [
+        ssgPlugin({
+          entry: entryFile,
+        }),
+      ],
+      build: {
+        rollupOptions: {
+          input: entryFile,
+          output: {
+            entryFileNames: 'assets/[name].js',
+          },
+        },
+        outDir: path.resolve(testDir, 'dist'),
+        emptyOutDir: true,
+      },
+    })
+
+    const entryOutputFile = path.resolve(testDir, 'dist', 'assets', 'app.js')
+
+    expect(fs.existsSync(outputFile)).toBe(true)
+    expect(fs.existsSync(entryOutputFile)).toBe(true)
+
+    const output = fs.readFileSync(outputFile, 'utf-8')
+    expect(output).toBe('<html><body><h1>Hello!</h1></body></html>')
+
+    const entryOutput = fs.readFileSync(entryOutputFile, 'utf-8')
+    expect(entryOutput.length).toBeGreaterThan(0)
+  })
 })