Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-pages): respect outputDir option #75

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ninebolt6
Copy link
Contributor

outputDir option exists but is not referenced in the production code.

This PR adds build.outDir to the plugin config to respect outputDir option.

Copy link

changeset-bot bot commented Feb 11, 2024

🦋 Changeset detected

Latest commit: 59ecf5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-cloudflare-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

yusukebe commented Feb 12, 2024

Hi @ninebolt6

Thanks. I'd like to merge this. So, could you run the yarn changeset at the top of the project? This is patch fix.

@ninebolt6
Copy link
Contributor Author

@yusukebe
There you go! 59ecf5a

@yusukebe
Copy link
Member

@ninebolt6 Okay! Merge now. Thanks!

@yusukebe yusukebe merged commit 50e640a into honojs:main Feb 12, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
@ninebolt6 ninebolt6 deleted the fix/output-dir branch February 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants