Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSDoc default values to the Cloudflare Pages plugin options #81

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

TheOnlyTails
Copy link
Contributor

We are using this plugin over at @lipu-linku, and we recently ran into a problem where the entry defaults screwed us over, since we are building a regular REST API, and not a React client side app.

This PR adds very simple JSDoc to the options, to allow users to see their default values in their editor, instead of having to look them up in a subfolder of a monorepo.

Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: 7ceb55f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yusukebe
Copy link
Member

Hi @TheOnlyTails

Thanks! This is a good improvement. I'll merge it now.

@yusukebe yusukebe merged commit 7b16cb4 into honojs:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants