Merge pull request #16 from hotgluexyz/fix/replicationKeys

Fix/replication keys
hotgluexyz · Feb 4, 2022 · 1320f76 · 1320f76
2 parents 12df852 + b3359c3
commit 1320f76
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/setup.py b/setup.py
@@ -4,7 +4,7 @@
 
 setup(
     name='tap-netsuite',
-    version='1.5.9',
+    version='1.5.10',
     description='Singer.io tap for extracting data from the NetSuite SOAP',
     author='hotglue',
     url='https://hotglue.xyz/',

diff --git a/tap_netsuite/__init__.py b/tap_netsuite/__init__.py
@@ -216,6 +216,8 @@ def do_discover(ns):
         if replication_key:
             mdata = metadata.write(
                 mdata, (), 'valid-replication-keys', [replication_key])
+            mdata = metadata.write(mdata, (), 'replication-key', replication_key)
+            mdata = metadata.write(mdata, (), 'replication-method', 'INCREMENTAL')
         else:
             mdata = metadata.write(
                 mdata,

diff --git a/tap_netsuite/netsuite/schemas/object_definition.json b/tap_netsuite/netsuite/schemas/object_definition.json
@@ -595,7 +595,7 @@
     {"displayName": "IsTaxable", "name": "isTaxable", "type": "string"},
     {"displayName": "ItemList", "name": "itemList", "type": "string"},
     {"displayName": "Job", "name": "job", "type": "string"},
-    {"displayName": "LastModifiedDate", "name": "lastModifiedDate", "type": "string"},
+    {"displayName": "LastModifiedDate", "name": "lastModifiedDate", "type": "datetime"},
     {"displayName": "LeadSource", "name": "leadSource", "type": "string"},
     {"displayName": "Location", "name": "location", "type": "string"},
     {"displayName": "Memo", "name": "memo", "type": "string"},
@@ -851,4 +851,4 @@
     {"displayName": "TranId", "name": "tranId", "type": "string"},
     {"displayName": "VatRegNum", "name": "vatRegNum", "type": "string"}
   ]
-}
+}
diff --git a/tap_netsuite/sync.py b/tap_netsuite/sync.py
@@ -129,7 +129,8 @@ def sync_records(ns, catalog_entry, state, counter):
                     time_extracted=start_time))
 
             if replication_key:
-                _rec = rec.get(replication_key, None)
+                __rec = {k.lower(): v for k, v in rec.items()}
+                _rec = __rec.get(replication_key.lower(), None)
                 original_replication_key_value = ""
                 replication_key_value = None
                 if replication_key and _rec is not None: