Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate index single page #1

Open
wants to merge 1 commit into
base: cndoc
Choose a base branch
from

Conversation

zhang2014
Copy link

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@blinkov
Copy link

blinkov commented Oct 8, 2018

@zhang2014 could you pull request this on top of https://github.com/yandex/ClickHouse/blob/master/docs/zh/index.md ? (remove the symlink and replace it with translation)

@sundy-li
Copy link
Member

sundy-li commented Oct 8, 2018

Note that Chinese has full-width punctuation, en version -> , . : ( ) , zh version -> ,。 :( )

@zhang2014
Copy link
Author

Ok, I'm glad to help you : )
but how about the review of Chinese documents ?

@sundy-li
Copy link
Member

sundy-li commented Oct 8, 2018

@blinkov
How about make @zhang2014 and me as Chinese doc reviewers ? Every Chinese doc translate pull request to ClickHouse, just assign the pr to one of us (could be more member in the future), and we will review the doc and decide if it could be merged.

@lamberken
Copy link
Collaborator

@zhang2014 @sundy-li 👍

@blinkov
Copy link

blinkov commented Oct 8, 2018

@sundy-li I'm not sure how many people will join to contribute to zh docs in official repo, but help with reviewing is also definitely appreciated. I'll try explicitly cc you in any relevant PR I see, thanks.

@zhang2014
Copy link
Author

track with the newest change on origin doc

@blinkov cc us when the origin doc changes : ) We'll synchronize the tasks to https://github.com/housepower/ClickHouse/projects/3

sundy-li pushed a commit that referenced this pull request Jan 11, 2019
Update 22   to click_update
sundy-li pushed a commit that referenced this pull request Mar 13, 2019
sundy-li pushed a commit that referenced this pull request Apr 25, 2019
Fixed bug in the example of using apt-key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants