handle negative decimals missing whole part

howeyc · Nov 10, 2023 · 4cdd173 · 4cdd173
1 parent 43dba38
commit 4cdd173
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/decimal/decimal.go b/decimal/decimal.go
@@ -84,7 +84,9 @@ func NewFromString(s string) (Decimal, error) {
 	if whole, frac, split := strings.Cut(s, "."); split {
 		var neg bool
 		var w int64
-		if whole != "" {
+		if whole == "-" {
+			neg = true
+		} else if whole != "" {
 			var err error
 			neg, w, err = atoi64(whole)
 			if err != nil {

diff --git a/decimal/decimal_test.go b/decimal/decimal_test.go
@@ -346,6 +346,11 @@ var testParseCases = []testCase{
 		"0.50",
 		".50",
 	},
+	{
+		"negmissingwhole",
+		"-0.50",
+		"-.50",
+	},
 }
 
 func TestStringParse(t *testing.T) {