forgot to include os library #5
Conversation
| @@ -76,7 +76,7 @@ resources: | |||
| flavor: { get_param: user_vm_flavor } | |||
| user_data: | | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
this is not ok
code should be kept in it's own files/scripts (so we can unittest or parse the), and incided here using the {get_file: some_file_name} directive
so move the script to a script, and use the get_file to include it (it also allows reuse in other templates)
There was a problem hiding this comment.
I agree with you on the idea to separate the code of the Python script from the heat template. In principle, when you create a stack with Horizon using a template, you can always include an environment file in a second field, and this how - I think - you have to pass on the Python script, but when you do so, you've got the following error message: "The value of get_file is mount_share.py inside the template. When launching a stack from this interface, the value must start with "http://" or "https://". Having googled around a bit, I have found that: "This is a limitation of Horizon - it can't access local files on your machine the way the CLI client can. The recommended way to launch stacks with nested templates using Horizon is to first upload them to Swift, and then reference by URL."
There was a problem hiding this comment.
that's a pity. but we need to find other ways to achieve this. this is too error prone
(and the script better adds the export to fstab)
@alvarosimon what options do we have to get eg some of our own python code in all the VMs? cloudinit?
There was a problem hiding this comment.
Mmm.. it works for me.
@StephaneGerardVUB have you tried this? I did a very stupid example with EB and also with some github public script files and it seems that is working, something like:
user_data:
get_file: https://raw.githubusercontent.com/alvarosimon/vsc_user_docs/master/deploy.sh
The only issue is the size of the file, it should be a few kilobytes because the file is injected into the metadata (but we can increase this limit if we want).
So I think that even for the tiny script @stdweird is right and we should include those scripts into a different directory in this repo and use them directly from our heat templates.
There was a problem hiding this comment.
Doing some tests but for a reason I don't understand, I can't find the export location path in the metadata anymore...
| os.mkdir(mountpoint) | ||
| os.chown(mountpoint,0,0) | ||
| os.system("mount %s %s" % (sharepath,mountpoint)) | ||
| user_data: { get_file: 'https://raw.githubusercontent.com/StephaneGerardVUB/openstack-templates/HeatTemplateWithShare/heat/examples/mount_share.py' } |
There was a problem hiding this comment.
don't reference your own fork, use the main repo (it will only work once this PR is merged)
There was a problem hiding this comment.
also do not use *.py extension, cloud-init is a bit stupid and only executes *.sh scripts
There was a problem hiding this comment.
@StephaneGerardVUB I have tested this PR directly from our openstack dashboard and it works! the only thing that we should change as @stdweird said is your personal URL by the final URL, do not use your personal github repo.
Also move the script to a new scripts directory. This will help us to keep yaml files and scripts in different places, it is cleaner and we can reuse these scripts quite easy.
There was a problem hiding this comment.
and I was mistaken *.py also works :-) cloud-init is quite agnostic about that
| os.mkdir(mountpoint) | ||
| os.chown(mountpoint,0,0) | ||
| os.system("mount %s %s" % (sharepath,mountpoint)) | ||
| user_data: { get_file: 'https://raw.githubusercontent.com/hpcugent/openstack-templates/HeatTemplateWithShare/heat/examples/mount_share.py' } |
There was a problem hiding this comment.
This URL is still not correct, HeatTemplateWithShare branch is not available from upstream, it should be changed by the master branch. Also move the script to a different directory like heat/scripts//mount_share.py.
So the URL should look like this:
user_data: { get_file: 'https://raw.githubusercontent.com/hpcugent/openstack-templates/master/heat/scripts/mount_share.py' }
If you move the scripts into ../heat/scripts folder.
heat/scripts/mount_share.py
Outdated
| @@ -0,0 +1,11 @@ | |||
| #!/usr/bin/env python | |||
| import os,json,re,requests | |||
There was a problem hiding this comment.
could you please import all the packages in different lines to follow PEP style guide?
https://www.python.org/dev/peps/pep-0008/#imports
No description provided.