Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde_json::from_slice to deserialize from &[u8] #28

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Use serde_json::from_slice to deserialize from &[u8] #28

merged 1 commit into from
Nov 8, 2018

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Nov 8, 2018

This makes it clear that there is no streaming going on, since deserializing a stream of bytes without first buffering into Vec<u8> is when you would typically see serde_json::from_reader come up.

This makes it clear that there is no streaming going on, since
deserializing a stream of bytes without first buffering into Vec<u8> is
when you would typically see serde_json::from_reader come up.
@aturon aturon merged commit 967d41f into http-rs:master Nov 8, 2018
@dtolnay dtolnay deleted the slice branch November 8, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants